Fixed onrequest path-related issue #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am wondering what's the exact "issue" this patch is solving? |
|
Path can change in onrequest. |
| @@ -449,10 +449,10 @@ request(Buffer, State=#state{socket=Socket, transport=Transport, | |||
| -spec onrequest(cowboy_req:req(), #state{}, binary(), binary()) -> ok. | |||
| onrequest(Req, State=#state{onrequest=undefined}, Host, Path) -> | |||
| dispatch(Req, State, Host, Path); | |||
| onrequest(Req, State=#state{onrequest=OnRequest}, Host, Path) -> | |||
| onrequest(Req, State=#state{onrequest=OnRequest}, Host, _Path) -> | |||
There was a problem hiding this comment.
Instead of not using it here can you remove this argument entirely? I'll merge when that's done. Thanks!
|
Just a small change and it's good! |
|
I am a little confused by your two comments above. Do you mean that you want me to remove the forth argument Path in the onrequest call entirely (which is a backward-compatibility issue), or that the change is good the way it is? |
|
Yes, remove, there's no backward there, it's an internal function. Just remove it on the caller too. |
|
ok, cool. |
|
Check it now. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.